[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/1] drive-mirror: add increment

From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/1] drive-mirror: add incremental mode
Date: Wed, 2 Jan 2019 09:47:45 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 1/2/19 4:04 AM, mahaocong wrote:
> From: mahaocong <address@hidden>
> Signed-off-by: mahaocong <address@hidden>

The subject line says "what" changed, but you are missing a commit body
that says "why" the change is useful.  Much of the content in your cover
letter should be copied into this commit body, as the cover letter does
not get stored into git.

> ---
>  block/mirror.c            | 55 
> ++++++++++++++++++++++++++++++++++++-----------
>  blockdev.c                | 37 +++++++++++++++++++++++++++++--
>  include/block/block_int.h |  3 ++-
>  qapi/block-core.json      |  9 +++++++-
>  4 files changed, 88 insertions(+), 16 deletions(-)

> +++ b/qapi/block-core.json
> @@ -1727,6 +1727,13 @@
>  #        (all the disk, only the sectors allocated in the topmost image, or
>  #        only new I/O).
>  #
> +# @bitmap: the name of user-created-bitmap which is used to initialize the
> +#          unnamed-bitmap used on incremental drive-mirror. It's hbitmap

"It's" should only be used when you could also have said "It is" or "It
has" - but in this sentence, you are using a possessive which is spelled
"Its".  However, the entire concept of an hbitmap is an internal
implementation detail, so I don't know if it makes sense to be
mentioning an hbitmap in this location.

> +#          will be copy to mirror bitmap. If user select incremental mode,
> +#          bitmap-name should not be null, and can not set granularity for
> +#          the mirror bitmap should have the same granularity with
> +#          user-created-bitmap.

Missing a '(since 4.0)' tag.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]