[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 02/11] block/dirty-bitmap: remove assertion f
|
From: |
Vladimir Sementsov-Ogievskiy |
|
Subject: |
Re: [Qemu-block] [PATCH v5 02/11] block/dirty-bitmap: remove assertion from restore |
|
Date: |
Thu, 20 Dec 2018 08:33:30 +0000 |
20.12.2018 5:29, John Snow wrote:
> When making a backup of a dirty bitmap (for transactions), we want to
> restore that backup whether or not the bitmap is enabled or not.
>
> It is perfectly valid to write into bitmaps that are disabled. It is
> only illegitimate for the guest to have done so.
>
> Remove this assertion.
>
> Signed-off-by: John Snow <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> block/dirty-bitmap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
> index 89fd1d7f8b..6b688394e4 100644
> --- a/block/dirty-bitmap.c
> +++ b/block/dirty-bitmap.c
> @@ -625,7 +625,6 @@ void bdrv_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap,
> HBitmap **out)
> void bdrv_restore_dirty_bitmap(BdrvDirtyBitmap *bitmap, HBitmap *backup)
> {
> HBitmap *tmp = bitmap->bitmap;
> - assert(bdrv_dirty_bitmap_enabled(bitmap));
> assert(!bdrv_dirty_bitmap_readonly(bitmap));
> bitmap->bitmap = backup;
> hbitmap_free(tmp);
>
--
Best regards,
Vladimir
- [Qemu-block] [PATCH v5 00/11] bitmaps: remove x- prefix from QMP api, John Snow, 2018/12/19
- [Qemu-block] [PATCH v5 02/11] block/dirty-bitmap: remove assertion from restore, John Snow, 2018/12/19
- [Qemu-block] [PATCH v5 03/11] blockdev: n-ary bitmap merge, John Snow, 2018/12/19
- [Qemu-block] [PATCH v5 01/11] blockdev: abort transactions in reverse order, John Snow, 2018/12/19
- [Qemu-block] [PATCH v5 04/11] block: remove 'x' prefix from experimental bitmap APIs, John Snow, 2018/12/19
- [Qemu-block] [PATCH v5 07/11] iotests: add qmp recursive sorting function, John Snow, 2018/12/19
- [Qemu-block] [PATCH v5 06/11] iotests: add filter_generated_node_ids, John Snow, 2018/12/19