Re: [Qemu-block] [PATCH v2 1/8] qcow2.h: add missing include

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 1/8] qcow2.h: add missing include

From:	Alberto Garcia
Subject:	Re: [Qemu-block] [PATCH v2 1/8] qcow2.h: add missing include
Date:	Thu, 13 Dec 2018 11:18:55 +0100
User-agent:	Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Tue 11 Dec 2018 05:43:10 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> qcow2.h depends on block_int.h. Compilation isn't broken currently only
> due to block_int.h always included before qcow2.h. Though, it seems
> better to directly include block_int.h in qcow2.h.

If you include block_int.h in qcow2.h then I guess there's no need to do
it again in qcow2.c

Berto

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-block] [PATCH v2 7/8] qcow2: bdrv_co_pwritev: move encryption code out of the lock, (continued)
- [Qemu-block] [PATCH v2 7/8] qcow2: bdrv_co_pwritev: move encryption code out of the lock, Vladimir Sementsov-Ogievskiy, 2018/12/11
- [Qemu-block] [PATCH v2 6/8] qcow2: qcow2_co_preadv: skip using hd_qiov when possible, Vladimir Sementsov-Ogievskiy, 2018/12/11
- [Qemu-block] [PATCH v2 4/8] qcow2-threads: split out generic path, Vladimir Sementsov-Ogievskiy, 2018/12/11
  - Re: [Qemu-block] [Qemu-devel] [PATCH v2 4/8] qcow2-threads: split out generic path, Paolo Bonzini, 2018/12/13
    - Re: [Qemu-block] [Qemu-devel] [PATCH v2 4/8] qcow2-threads: split out generic path, Vladimir Sementsov-Ogievskiy, 2018/12/14
- [Qemu-block] [PATCH v2 3/8] qcow2-threads: use thread_pool_submit_co, Vladimir Sementsov-Ogievskiy, 2018/12/11
- [Qemu-block] [PATCH v2 8/8] qcow2: do encryption in threads, Vladimir Sementsov-Ogievskiy, 2018/12/11
- [Qemu-block] [PATCH v2 2/8] qcow2: add separate file for threaded data processing functions, Vladimir Sementsov-Ogievskiy, 2018/12/11
- [Qemu-block] [PATCH v2 5/8] qcow2: qcow2_co_preadv: improve locking, Vladimir Sementsov-Ogievskiy, 2018/12/11
- [Qemu-block] [PATCH v2 1/8] qcow2.h: add missing include, Vladimir Sementsov-Ogievskiy, 2018/12/11
  - Re: [Qemu-block] [PATCH v2 1/8] qcow2.h: add missing include, Alberto Garcia <=
- Re: [Qemu-block] [PATCH v2 0/8] qcow2: encryption threads, Daniel P . Berrangé, 2018/12/11
- Re: [Qemu-block] [PATCH v2 0/8] qcow2: encryption threads, Vladimir Sementsov-Ogievskiy, 2018/12/17

Prev by Date: Re: [Qemu-block] [Qemu-devel] [PATCH RFC] qemu-io: Prefer stderr for error messages
Next by Date: Re: [Qemu-block] [Qemu-devel] [PATCH RFC] qemu-io: Prefer stderr for error messages
Previous by thread: [Qemu-block] [PATCH v2 1/8] qcow2.h: add missing include
Next by thread: Re: [Qemu-block] [PATCH v2 0/8] qcow2: encryption threads
Index(es):
- Date
- Thread