[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 6/6] tests: exercise NBD server in TLS mode
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-block] [PATCH 6/6] tests: exercise NBD server in TLS mode |
Date: |
Mon, 19 Nov 2018 10:39:14 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Sat, Nov 17, 2018 at 02:49:22PM -0600, Eric Blake wrote:
> On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
> > Add tests that validate it is possible to connect to an NBD server
> > running TLS mode. Also test mis-matched TLS vs non-TLS connections
> > correctly fail.
> > ---
>
> Missing your Signed-off-by. Can you please supply that, so I can include
> this in my pull request?
Signed-off-by: Daniel P. Berrangé <address@hidden>
>
> Also, I'm getting failures when trying to test it:
>
> @@ -17,9 +17,9 @@
>
> == check plain client to TLS server fails ==
> option negotiation failed: read failed: Unexpected end-of-file before all
> bytes were read
> +write failed (error message): Unable to write to socket: Broken pipe
> qemu-img: Could not open 'nbd://localhost:10809': TLS negotiation required
> before option 8 (structured reply)
> server reported: Option 0x8 not permitted before TLS
> -write failed (error message): Unable to write to socket: Broken pipe
>
>
> which looks like an output race. :(
Guess that shows the message is in fact coming from the server rather
than the client then.
We could just silence the qemu-nbd process to null, since we're primarily
interested in what the client displays in this test
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Re: [Qemu-block] [PATCH 6/6] tests: exercise NBD server in TLS mode, Eric Blake, 2018/11/17
Re: [Qemu-block] [PATCH 6/6] tests: exercise NBD server in TLS mode,
Daniel P . Berrangé <=
[Qemu-block] [PATCH 7/6] iotests: Also test I/O over NBD TLS, Eric Blake, 2018/11/17
Re: [Qemu-block] [PATCH 6/6] tests: exercise NBD server in TLS mode, Eric Blake, 2018/11/19
Re: [Qemu-block] [PATCH 6/6] tests: exercise NBD server in TLS mode, Kevin Wolf, 2018/11/20
- Re: [Qemu-block] [PATCH 6/6] tests: exercise NBD server in TLS mode, Eric Blake, 2018/11/20
- Re: [Qemu-block] [PATCH 6/6] tests: exercise NBD server in TLS mode, Daniel P . Berrangé, 2018/11/20
- Re: [Qemu-block] [PATCH 6/6] tests: exercise NBD server in TLS mode, Eric Blake, 2018/11/20
- Re: [Qemu-block] [PATCH 6/6] tests: exercise NBD server in TLS mode, Kevin Wolf, 2018/11/20
- Re: [Qemu-block] [PATCH 6/6] tests: exercise NBD server in TLS mode, Daniel P . Berrangé, 2018/11/21