[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 7/7] qcow2: do decompression in threads
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-block] [PATCH 7/7] qcow2: do decompression in threads |
Date: |
Thu, 1 Nov 2018 21:27:38 +0300 |
Do decompression in threads, like it is already done for compression.
This improves asynchronous compressed reads performance.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
block/qcow2.c | 35 ++++++++++++++++++++++++++++-------
1 file changed, 28 insertions(+), 7 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 678d737044..3f1c773b13 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -3802,20 +3802,24 @@ static ssize_t qcow2_decompress(void *dest, size_t
dest_size,
#define MAX_COMPRESS_THREADS 4
+typedef ssize_t (*Qcow2CompressFunc)(void *dest, size_t dest_size,
+ const void *src, size_t src_size);
typedef struct Qcow2CompressData {
void *dest;
size_t dest_size;
const void *src;
size_t src_size;
ssize_t ret;
+
+ Qcow2CompressFunc func;
} Qcow2CompressData;
static int qcow2_compress_pool_func(void *opaque)
{
Qcow2CompressData *data = opaque;
- data->ret = qcow2_compress(data->dest, data->dest_size,
- data->src, data->src_size);
+ data->ret = data->func(data->dest, data->dest_size,
+ data->src, data->src_size);
return 0;
}
@@ -3825,10 +3829,10 @@ static void qcow2_compress_complete(void *opaque, int
ret)
qemu_coroutine_enter(opaque);
}
-/* See qcow2_compress definition for parameters description */
-static ssize_t qcow2_co_compress(BlockDriverState *bs,
- void *dest, size_t dest_size,
- const void *src, size_t src_size)
+static ssize_t qcow2_co_do_compress(BlockDriverState *bs,
+ void *dest, size_t dest_size,
+ const void *src, size_t src_size,
+ Qcow2CompressFunc func)
{
BDRVQcow2State *s = bs->opaque;
BlockAIOCB *acb;
@@ -3838,6 +3842,7 @@ static ssize_t qcow2_co_compress(BlockDriverState *bs,
.dest_size = dest_size,
.src = src,
.src_size = src_size,
+ .func = func,
};
while (s->nb_compress_threads >= MAX_COMPRESS_THREADS) {
@@ -3860,6 +3865,22 @@ static ssize_t qcow2_co_compress(BlockDriverState *bs,
return arg.ret;
}
+static ssize_t qcow2_co_compress(BlockDriverState *bs,
+ void *dest, size_t dest_size,
+ const void *src, size_t src_size)
+{
+ return qcow2_co_do_compress(bs, dest, dest_size, src, src_size,
+ qcow2_compress);
+}
+
+static ssize_t qcow2_co_decompress(BlockDriverState *bs,
+ void *dest, size_t dest_size,
+ const void *src, size_t src_size)
+{
+ return qcow2_co_do_compress(bs, dest, dest_size, src, src_size,
+ qcow2_decompress);
+}
+
/* XXX: put compressed sectors first, then all the cluster aligned
tables to avoid losing bytes in alignment */
static coroutine_fn int
@@ -3987,7 +4008,7 @@ static int qcow2_co_preadv_compressed(BlockDriverState
*bs,
goto fail;
}
- if (qcow2_decompress(out_buf, s->cluster_size, buf, csize) < 0) {
+ if (qcow2_co_decompress(bs, out_buf, s->cluster_size, buf, csize) < 0) {
ret = -EIO;
goto fail;
}
--
2.18.0
- [Qemu-block] [PATCH 0/7] qcow2 decompress in threads, Vladimir Sementsov-Ogievskiy, 2018/11/01
- [Qemu-block] [PATCH 5/7] qcow2: use byte-based read in qcow2_decompress_cluster, Vladimir Sementsov-Ogievskiy, 2018/11/01
- [Qemu-block] [PATCH 7/7] qcow2: do decompression in threads,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-block] [PATCH 2/7] qcow2: make more generic interface for qcow2_compress, Vladimir Sementsov-Ogievskiy, 2018/11/01
- [Qemu-block] [PATCH 4/7] qcow2: refactor decompress_buffer, Vladimir Sementsov-Ogievskiy, 2018/11/01
- [Qemu-block] [PATCH 3/7] qcow2: move decompression from qcow2-cluster.c to qcow2.c, Vladimir Sementsov-Ogievskiy, 2018/11/01
- [Qemu-block] [PATCH 1/7] qcow2: use Z_OK instead of 0 for deflateInit2 return code check, Vladimir Sementsov-Ogievskiy, 2018/11/01