[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 01/14] block: Don't call update_flags_from_optio
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH 01/14] block: Don't call update_flags_from_options() if the options are wrong |
Date: |
Mon, 8 Oct 2018 02:43:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 19.09.18 16:47, Alberto Garcia wrote:
> If qemu_opts_absorb_qdict() fails and we carry on and call
> update_flags_from_options() then that can result on a failed
> assertion:
>
> $ qemu-io -c 'reopen -o read-only=foo' hd.qcow2
> block.c:1101: update_flags_from_options: Assertion `qemu_opt_find(opts,
> BDRV_OPT_CACHE_DIRECT)' failed.
> Aborted
>
> This only happens in bdrv_reopen_queue_child(). Although this function
> doesn't return errors, we can simply keep the wrong options in the
> reopen queue and later bdrv_reopen_prepare() will fail.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> block.c | 11 +++++++++--
> tests/qemu-iotests/133 | 6 ++++++
> tests/qemu-iotests/133.out | 4 ++++
> 3 files changed, 19 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-block] [PATCH 01/14] block: Don't call update_flags_from_options() if the options are wrong,
Max Reitz <=