[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v11 30/31] block: BDS options may lack the "driver"
From: |
Max Reitz |
Subject: |
[Qemu-block] [PATCH v11 30/31] block: BDS options may lack the "driver" option |
Date: |
Sat, 6 Oct 2018 01:40:22 +0200 |
When BDSs are created by qemu itself (e.g. as filters in block jobs),
they may not have a "driver" option in their options QDict. When
generating a json:{} filename, however, it must always be present.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
---
block.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block.c b/block.c
index 041adb90d1..ecb228b8f8 100644
--- a/block.c
+++ b/block.c
@@ -5306,6 +5306,12 @@ static bool append_strong_runtime_options(QDict *d,
BlockDriverState *bs)
}
}
+ if (!qdict_haskey(d, "driver")) {
+ /* Drivers created with bdrv_new_open_driver() may not have a
+ * @driver option. Add it here. */
+ qdict_put_str(d, "driver", bs->drv->format_name);
+ }
+
return found_any;
}
--
2.17.1
- [Qemu-block] [PATCH v11 22/31] block: Add BlockDriver.bdrv_gather_child_options, (continued)
- [Qemu-block] [PATCH v11 22/31] block: Add BlockDriver.bdrv_gather_child_options, Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 21/31] block: Add strong_runtime_opts to BlockDriver, Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 23/31] block: Generically refresh runtime options, Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 27/31] block/curl: Harmonize option defaults, Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 26/31] block/nvme: Fix bdrv_refresh_filename(), Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 25/31] block: Do not copy exact_filename from format file, Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 24/31] block: Purify .bdrv_refresh_filename(), Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 29/31] block/null: Generate filename even with latency-ns, Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 28/31] block/curl: Implement bdrv_refresh_filename(), Max Reitz, 2018/10/05
- [Qemu-block] [PATCH v11 30/31] block: BDS options may lack the "driver" option,
Max Reitz <=
- [Qemu-block] [PATCH v11 31/31] iotests: Test json:{} filenames of internal BDSs, Max Reitz, 2018/10/05