[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 5/6] block/backup: prohibit backup from using
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-block] [PATCH v4 5/6] block/backup: prohibit backup from using in use bitmaps |
Date: |
Wed, 3 Oct 2018 14:04:11 +0000 |
03.10.2018 02:02, John Snow wrote:
> If the bitmap is frozen, we shouldn't touch it.
>
> Signed-off-by: John Snow <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> blockdev.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index d0febfca79..098d4c337f 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -3512,10 +3512,10 @@ static BlockJob *do_drive_backup(DriveBackup *backup,
> JobTxn *txn,
> bdrv_unref(target_bs);
> goto out;
> }
> - if (bdrv_dirty_bitmap_qmp_locked(bmap)) {
> + if (bdrv_dirty_bitmap_user_locked(bmap)) {
> error_setg(errp,
> - "Bitmap '%s' is currently locked and cannot be used
> for "
> - "backup", backup->bitmap);
> + "Bitmap '%s' is currently in use by another operation"
> + " and cannot be used for backup", backup->bitmap);
> goto out;
> }
> }
> @@ -3620,10 +3620,10 @@ BlockJob *do_blockdev_backup(BlockdevBackup *backup,
> JobTxn *txn,
> error_setg(errp, "Bitmap '%s' could not be found",
> backup->bitmap);
> goto out;
> }
> - if (bdrv_dirty_bitmap_qmp_locked(bmap)) {
> + if (bdrv_dirty_bitmap_user_locked(bmap)) {
> error_setg(errp,
> - "Bitmap '%s' is currently locked and cannot be used
> for "
> - "backup", backup->bitmap);
> + "Bitmap '%s' is currently in use by another operation"
> + " and cannot be used for backup", backup->bitmap);
> goto out;
> }
> }
--
Best regards,
Vladimir
- [Qemu-block] [PATCH v4 6/6] nbd: forbid use of frozen bitmaps, (continued)
- [Qemu-block] [PATCH v4 6/6] nbd: forbid use of frozen bitmaps, John Snow, 2018/10/02
- [Qemu-block] [PATCH v4 2/6] block/dirty-bitmaps: fix merge permissions, John Snow, 2018/10/02
- [Qemu-block] [PATCH v4 5/6] block/backup: prohibit backup from using in use bitmaps, John Snow, 2018/10/02
- [Qemu-block] [PATCH v4 4/6] block/dirty-bitmaps: prohibit enable/disable on locked/frozen bitmaps, John Snow, 2018/10/02
- Re: [Qemu-block] [PATCH v4 0/6] dirty-bitmaps: fix QMP command permissions, John Snow, 2018/10/03
- Re: [Qemu-block] [PATCH v4 0/6] dirty-bitmaps: fix QMP command permissions, Eric Blake, 2018/10/17