[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 04/16] block/commit: refactor commit to use j
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v5 04/16] block/commit: refactor commit to use job callbacks |
Date: |
Sat, 8 Sep 2018 01:14:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-09-06 15:02, John Snow wrote:
> Use the component callbacks; prepare, abort, and clean.
>
> NB: prepare is only called when the job has not yet failed;
> and abort can be called after prepare.
>
> complete -> prepare -> abort -> clean
> complete -> abort -> clean
>
> During refactor, a potential problem with bdrv_drop_intermediate
> was identified, The patched behavior is no worse than the pre-patch
(s/T/t/)
(Max)
> behavior, so leave a FIXME for now to be fixed in a future patch.
>
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
> block/commit.c | 92
> ++++++++++++++++++++++++++++++++--------------------------
> 1 file changed, 51 insertions(+), 41 deletions(-)
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v5 05/16] block/mirror: don't install backing chain on abort, (continued)
- [Qemu-block] [PATCH v5 05/16] block/mirror: don't install backing chain on abort, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 02/16] block/mirror: add block job creation flags, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 10/16] tests/test-blockjob-txn: move .exit to .clean, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 14/16] qapi/block-stream: expose new job properties, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 04/16] block/commit: refactor commit to use job callbacks, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 11/16] jobs: remove .exit callback, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 09/16] tests/test-blockjob: remove exit callback, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 07/16] block/stream: refactor stream to use job callbacks, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 13/16] qapi/block-mirror: expose new job properties, John Snow, 2018/09/06
- [Qemu-block] [PATCH v5 16/16] blockdev: document transactional shortcomings, John Snow, 2018/09/06