[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v3 01/10] qemu-io: Fix writethrough check in reopen
From: |
Alberto Garcia |
Subject: |
[Qemu-block] [PATCH v3 01/10] qemu-io: Fix writethrough check in reopen |
Date: |
Thu, 6 Sep 2018 12:37:01 +0300 |
"qemu-io reopen" doesn't allow changing the writethrough setting of
the cache, but the check is wrong, causing an error even on a simple
reopen with the default parameters:
$ qemu-img create -f qcow2 hd.qcow2 1M
$ qemu-system-x86_64 -monitor stdio -drive if=virtio,file=hd.qcow2
(qemu) qemu-io virtio0 reopen
Cannot change cache.writeback: Device attached
Signed-off-by: Alberto Garcia <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
qemu-io-cmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index 5bf5f28178..db0b3ee5ef 100644
--- a/qemu-io-cmds.c
+++ b/qemu-io-cmds.c
@@ -2025,7 +2025,7 @@ static int reopen_f(BlockBackend *blk, int argc, char
**argv)
return -EINVAL;
}
- if (writethrough != blk_enable_write_cache(blk) &&
+ if (!writethrough != blk_enable_write_cache(blk) &&
blk_get_attached_dev(blk))
{
error_report("Cannot change cache.writeback: Device attached");
--
2.11.0
- Re: [Qemu-block] [PATCH v3 08/10] block: Allow changing 'discard' on reopen, (continued)
[Qemu-block] [PATCH v3 05/10] block: Allow child references on reopen, Alberto Garcia, 2018/09/06
[Qemu-block] [PATCH v3 09/10] block: Allow changing 'detect-zeroes' on reopen, Alberto Garcia, 2018/09/06
[Qemu-block] [PATCH v3 02/10] file-posix: x-check-cache-dropped should default to false on reopen, Alberto Garcia, 2018/09/06
[Qemu-block] [PATCH v3 03/10] block: Remove child references from bs->{options, explicit_options}, Alberto Garcia, 2018/09/06
[Qemu-block] [PATCH v3 06/10] block: Forbid trying to change unsupported options during reopen, Alberto Garcia, 2018/09/06
[Qemu-block] [PATCH v3 04/10] block: Don't look for child references in append_open_options(), Alberto Garcia, 2018/09/06
[Qemu-block] [PATCH v3 01/10] qemu-io: Fix writethrough check in reopen,
Alberto Garcia <=
[Qemu-block] [PATCH v3 07/10] file-posix: Forbid trying to change unsupported options during reopen, Alberto Garcia, 2018/09/06
[Qemu-block] [PATCH v3 10/10] block: Allow changing 'force-share' on reopen, Alberto Garcia, 2018/09/06