Re: [Qemu-block] [PATCH 2/9] file-posix: x-check-cache-dropped should default to false on reopen

[Max Reitz]

On 2018-08-26 16:09, Alberto Garcia wrote:
> The default value of x-check-cache-dropped is false. There's no reason
> to use the previous value as a default in raw_reopen_prepare() because
> bdrv_reopen_queue_child() already takes care of putting the old
> options in the BDRVReopenState.options QDict.

Well, the reason would be because one might want to retain unspecified
values as they were set before.  But we decided we don't want to do that.

> If x-check-cache-dropped was previously set but is now missing from
> the reopen QDict then it should be reset to false.
> 
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
>  block/file-posix.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

So:

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature