[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 1/9] jobs: change start callback to run callb
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v2 1/9] jobs: change start callback to run callback |
Date: |
Mon, 27 Aug 2018 11:30:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-08-24 00:08, John Snow wrote:
> Presently we codify the entry point for a job as the "start" callback,
> but a more apt name would be "run" to clarify the idea that when this
> function returns we consider the job to have "finished," except for
> any cleanup which occurs in separate callbacks later.
>
> As part of this clarification, change the signature to include an error
> object and a return code. The error ptr is not yet used, and the return
> code while captured, will be overwritten by actions in the job_completed
> function.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> block/backup.c | 7 ++++---
> block/commit.c | 7 ++++---
> block/create.c | 8 +++++---
> block/mirror.c | 10 ++++++----
> block/stream.c | 7 ++++---
> include/qemu/job.h | 2 +-
> job.c | 6 +++---
> tests/test-bdrv-drain.c | 7 ++++---
> tests/test-blockjob-txn.c | 16 ++++++++--------
> tests/test-blockjob.c | 7 ++++---
> 10 files changed, 43 insertions(+), 34 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
But I see a discrepancy in the upcoming s->ret <=> s->err relationship
now. And that is if .run() doesn't return an Error *...
That could be remedied immediately in job_co_entry(), though, either by
calling job_update_rc(), or by inlining its "if (!job->err)" part.
Max
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v2 8/9] jobs: remove ret argument to job_completed; privatize it, (continued)
- [Qemu-block] [PATCH v2 6/9] jobs: utilize job_exit shim, John Snow, 2018/08/23
- [Qemu-block] [PATCH v2 9/9] jobs: remove job_defer_to_main_loop, John Snow, 2018/08/23
- [Qemu-block] [PATCH v2 7/9] block/backup: make function variables consistently named, John Snow, 2018/08/23
- [Qemu-block] [PATCH v2 4/9] block/commit: utilize job_exit shim, John Snow, 2018/08/23
- [Qemu-block] [PATCH v2 1/9] jobs: change start callback to run callback, John Snow, 2018/08/23
- Re: [Qemu-block] [PATCH v2 1/9] jobs: change start callback to run callback,
Max Reitz <=