Re: [Qemu-block] [Qemu-devel] [PATCH] block: for jobs, do not clear user_paused until after the resume

[Eric Blake]

On 08/15/2018 10:59 AM, Jeff Cody wrote:
> The function job_cancel_async() will always cause an assert for blockjob
> user resume.  We set job->user_paused to false, and then call
> job->driver->user_resume().  In the case of blockjobs, this is the
> block_job_user_resume() function.
>
> In that function, we assert that job.user_paused is set to true.
> Unfortunately, right before calling this function, it has explicitly
> been set to false.
>
> The fix is pretty simple: set job->user_paused to false only after the
> job user_resume() function has been called.
>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
>   job.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Does this need to CC qemu-stable?

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org