[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 33/33] tests/qgraph: temporarly commented vhost-
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-block] [PATCH 33/33] tests/qgraph: temporarly commented vhost-user-test |
|
Date: |
Mon, 13 Aug 2018 14:15:26 +0300 |
On Mon, Aug 13, 2018 at 12:14:53PM +0200, Emanuele Giuseppe Esposito wrote:
> vhost-user-test has not converted to qgraph yet, and since
> it uses virtio interface, it won't work, causing make check
> to fail.
> Commented out until it does not get converted to graph node.
>
> Signed-off-by: Emanuele Giuseppe Esposito <address@hidden>
Two problems with that
- we lose vhost user coverage
- bisecting to before patch 33 will leave us with
a failing make check
Thoughts?
> ---
> tests/Makefile.include | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 15926cc95f..30355058fc 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -287,10 +287,10 @@ check-qtest-i386-y += tests/cpu-plug-test$(EXESUF)
> check-qtest-i386-y += tests/q35-test$(EXESUF)
> check-qtest-i386-y += tests/vmgenid-test$(EXESUF)
> gcov-files-i386-y += hw/pci-host/q35.c
> -check-qtest-i386-$(CONFIG_VHOST_USER_NET_TEST_i386) +=
> tests/vhost-user-test$(EXESUF)
> -ifeq ($(CONFIG_VHOST_USER_NET_TEST_i386),)
> -check-qtest-x86_64-$(CONFIG_VHOST_USER_NET_TEST_x86_64) +=
> tests/vhost-user-test$(EXESUF)
> -endif
> +# check-qtest-i386-$(CONFIG_VHOST_USER_NET_TEST_i386) +=
> tests/vhost-user-test$(EXESUF)
> +# ifeq ($(CONFIG_VHOST_USER_NET_TEST_i386),)
> +# check-qtest-x86_64-$(CONFIG_VHOST_USER_NET_TEST_x86_64) +=
> tests/vhost-user-test$(EXESUF)
> +# endif
> check-qtest-i386-$(CONFIG_TPM) += tests/tpm-crb-swtpm-test$(EXESUF)
> check-qtest-i386-$(CONFIG_TPM) += tests/tpm-crb-test$(EXESUF)
> check-qtest-i386-$(CONFIG_TPM) += tests/tpm-tis-swtpm-test$(EXESUF)
> --
> 2.17.1
- [Qemu-block] [PATCH 14/33] tests/qgraph: virtio-pci driver and interface nodes, (continued)
- [Qemu-block] [PATCH 14/33] tests/qgraph: virtio-pci driver and interface nodes, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-block] [PATCH 16/33] tests/qgraph: arm/virt machine node, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-block] [PATCH 26/33] tests/qgraph: virtio-rng test node, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-block] [PATCH 30/33] tests/qgraph: virtio-net test node, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-block] [PATCH 32/33] tests/qgraph: virtio-scsi test node, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-block] [PATCH 20/33] tests/qgraph: virtio-serial test node, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-block] [PATCH 21/33] tests/qgraph: virtio-9p driver and interface nodes, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-block] [PATCH 22/33] tests/qgraph: virtio-9p test node, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-block] [PATCH 29/33] tests/qgraph: virtio-net driver and interface nodes, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-block] [PATCH 33/33] tests/qgraph: temporarly commented vhost-user-test, Emanuele Giuseppe Esposito, 2018/08/13
- Re: [Qemu-block] [PATCH 33/33] tests/qgraph: temporarly commented vhost-user-test,
Michael S. Tsirkin <=
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/33] Qtest driver framework, Markus Armbruster, 2018/08/15