Re: [Qemu-block] [PATCH v2 4/5] qcow2: Set the default cache-clean-interval to 30 seconds

[Leonid Bloch]

On 08/07/2018 11:34 PM, Eric Blake wrote:
> On 08/07/2018 03:21 PM, Leonid Bloch wrote:
> > The default cache-clean-interval is set to 30 seconds, in order to lower
> > the overhead of the qcow2 caches.
> >
> > Signed-off-by: Leonid Bloch <address@hidden>
> > ---
>
> > +++ b/qapi/block-core.json
> > @@ -2830,7 +2830,8 @@
> >   #
> >   # @cache-clean-interval:  clean unused entries in the L2 and refcount
> >   #                         caches. The interval is in seconds. The 
> > default value
> > -#                         is 0 and it disables this feature (since 2.5)
> > +#                         is 30. (since 2.5)
> > +#
> >   # @encrypt:               Image decryption options. Mandatory for
> >   #                         encrypted images, except when doing a 
> > metadata-only
> >   #                         probe of the image. (since 2.10)
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index d6e15b2f06..0cda3d3c3a 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -767,7 +767,7 @@ it which is not used for the L2 cache)
> >   @item cache-clean-interval
> >   Clean unused entries in the L2 and refcount caches. The interval is 
> > in seconds.
> > -The default value is 0 and it disables this feature.
> > +The default value is 30.
>
> May be worth wording as:
>
> The default value is 30, while setting it to 0 disables this feature.

Definitely! Thanks! Will fix.