[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 19/21] qapi/block-commit: expose ne
From: |
John Snow |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 19/21] qapi/block-commit: expose new job properties |
Date: |
Tue, 7 Aug 2018 14:11:49 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 08/07/2018 10:52 AM, Eric Blake wrote:
> On 08/06/2018 11:33 PM, John Snow wrote:
>> Signed-off-by: John Snow <address@hidden>
>> ---
>> blockdev.c | 8 ++++++++
>> qapi/block-core.json | 3 ++-
>> 2 files changed, 10 insertions(+), 1 deletion(-)
>>
>
>> +++ b/qapi/block-core.json
>> @@ -1518,7 +1518,8 @@
>> { 'command': 'block-commit',
>> 'data': { '*job-id': 'str', 'device': 'str', '*base': 'str',
>> '*top': 'str',
>> '*backing-file': 'str', '*speed': 'int',
>> - '*filter-node-name': 'str' } }
>> + '*filter-node-name': 'str',
>> + '*auto-finalize': 'bool', '*auto-dismiss': 'bool' } }
>
> Missing documentation, including a 'since 3.1' tag.
>
OK, will fix for V2 but I won't respin until I get more feedback.
--js
- Re: [Qemu-block] [PATCH 02/21] jobs: add exit shim, (continued)
[Qemu-block] [PATCH 06/21] block/stream: utilize job_exit shim, John Snow, 2018/08/07
[Qemu-block] [PATCH 10/21] tests/test-bdrv-drain: utilize job_exit shim, John Snow, 2018/08/07
[Qemu-block] [PATCH 20/21] qapi/block-mirror: expose new job properties, John Snow, 2018/08/07
[Qemu-block] [PATCH 12/21] jobs: allow entrypoints to return status code, John Snow, 2018/08/07
[Qemu-block] [PATCH 19/21] qapi/block-commit: expose new job properties, John Snow, 2018/08/07
[Qemu-block] [PATCH 15/21] block/stream: add block job creation flags, John Snow, 2018/08/07
[Qemu-block] [PATCH 11/21] jobs: remove job_defer_to_main_loop, John Snow, 2018/08/07
[Qemu-block] [PATCH 14/21] block/mirror: add block job creation flags, John Snow, 2018/08/07
[Qemu-block] [PATCH 16/21] block/commit: refactor commit to use job callbacks, John Snow, 2018/08/07
[Qemu-block] [PATCH 18/21] block/commit: refactor stream to use job callbacks, John Snow, 2018/08/07