[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] qapi/block: Document restrictions for node name
From: |
Cong Li |
Subject: |
Re: [Qemu-block] [PATCH] qapi/block: Document restrictions for node names |
Date: |
Mon, 6 Aug 2018 22:38:45 -0400 (EDT) |
----- Original Message -----
> From: "Kevin Wolf" <address@hidden>
> To: address@hidden
> Cc: address@hidden, address@hidden, address@hidden
> Sent: Monday, August 6, 2018 8:37:28 PM
> Subject: [PATCH] qapi/block: Document restrictions for node names
>
> blockdev-add fails if an invalid node name is given, so we should
> document what a valid node name even is.
>
> Reported-by: Cong Li <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Cong Li <address@hidden>
> ---
> qapi/block-core.json | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 62a92fa4f4..fe565ebfaf 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -3563,6 +3563,9 @@
> # @driver: block driver name
> # @node-name: the node name of the new node (Since 2.0).
> # This option is required on the top level of blockdev-add.
> +# Valid node names start with an alphabetic character and
> may
> +# contain only alphanumeric characters, '-', '.' and '_'.
> Their
> +# maximum length is 31 characters.
> # @discard: discard-related options (default: ignore)
> # @cache: cache-related options
> # @read-only: whether the block device should be read-only (default:
> false).
> --
> 2.13.6
>
>