qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 3/6 for-3.0] qcow2: Options' documentation fixes


From: Leonid Bloch
Subject: Re: [Qemu-block] [PATCH 3/6 for-3.0] qcow2: Options' documentation fixes
Date: Sat, 4 Aug 2018 14:52:28 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 08/03/2018 02:27 PM, Alberto Garcia wrote:
On Sun 29 Jul 2018 11:27:41 PM CEST, Leonid Bloch wrote:
Signed-off-by: Leonid Bloch <address@hidden>
---
  docs/qcow2-cache.txt |  9 ++++++---
  qapi/block-core.json |  6 +++---
  qemu-options.hx      | 15 +++++++++------
  3 files changed, 18 insertions(+), 12 deletions(-)

diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
index 8a09a5cc5f..fd9a6911cc 100644
--- a/docs/qcow2-cache.txt
+++ b/docs/qcow2-cache.txt
@@ -112,9 +112,9 @@ command-line, or the 'blockdev-add' QMP command.
There are three options available, and all of them take bytes: -"l2-cache-size": maximum size of the L2 table cache
-"refcount-cache-size":   maximum size of the refcount block cache
-"cache-size":            maximum size of both caches combined
+"l2-cache-size":         maximal size of the L2 table cache
+"refcount-cache-size":   maximal size of the refcount block cache
+"cache-size":            maximal size of both caches combined

Why is 'maximum' not clear in this context?

It seemed to me that it is grammatically incorrect, because maximum is a noun and maximal is an adjective. But after a quick check now I see that maximum can be used as an adjective as well, so indeed this change is not needed. Will update in the next version.

Thanks,
Leonid.


Otherwise the patch looks good to me.

Berto




reply via email to

[Prev in Thread] Current Thread [Next in Thread]