[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] iotests: remove LUKS support from test 226
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH] iotests: remove LUKS support from test 226 |
Date: |
Fri, 13 Jul 2018 09:09:20 +0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 13.07.2018 um 00:12 hat John Snow geschrieben:
> This test doesn't actually care about the format anyway, it just
> supports "all formats" as a convenience. LUKS however does not use a
> simple image filename which confuses this iotest.
>
> We can simply remove the LUKS "support" and be happier for it.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> tests/qemu-iotests/226 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/qemu-iotests/226 b/tests/qemu-iotests/226
> index 460aea2fc9..ebfaf62e53 100755
> --- a/tests/qemu-iotests/226
> +++ b/tests/qemu-iotests/226
> @@ -40,7 +40,9 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
> . ./common.pattern
>
> # Generic format, but tests file-protocol specific error handling
> +# LUKS does not use a simple filename; this test doesn't use the format
> anyway.
> _supported_fmt generic
> +_unsupported_fmt luks
> _supported_proto file
> _supported_os Linux
Maybe it would be better to test for $IMGOPTSSYNTAX = "true", because
that's the real problem here?
Kevin