Re: [Qemu-block] [PATCH v3 00/10] block: Fix dst reading after tail copy offloading

[Kevin Wolf]

Am 10.07.2018 um 08:31 hat Fam Zheng geschrieben:
> Based-on: address@hidden
> 
> v3: - Rebase onto Vladmir's:
>       [PATCH v5 0/4] fix image fleecing
>       on top of master, which has blklogwrites to be converted to BdrvChild 
> for
>       the bdrv_co_pdiscard() parameter.  [Kevin]
>     - Add file_ prefix to file protocol trace points. [Kevin]
>     - Assert that BdrvTrackedRequest bytes and offset don't overflow 
> INT64_MAX.
>       [Kevin]
>     - Don't misuse req->offset/req->bytes in bdrv_co_write_req_prepare/finish.
>       [Kevin]
>     - Fix stat64_max. [Kevin]
>     - Keep lines within 80 columns. [Kevin]
>     - Grammar fix in commit message and rev-by. [Eric]
> 
> Qcow2 allocates new clusters after the end of the file. If it is the 
> destinaton
> of copy offloading, we must adjust dst->bs->total_sectors. Otherwise, further
> reads will drop to the "beyond EOF" code path and return zeroes, which problem
> is caught by iotests 222.
> 
> Follow the logic in the normal write code and update bs->total_sectors after
> I/O is done.
> 
> While at it, add a few convenient trace points to aid future debug experiences
> in the topic.

Thanks, applied to the block branch.

Kevin