[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v4 0/4] fix image fleecing
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-block] [PATCH v4 0/4] fix image fleecing |
Date: |
Fri, 6 Jul 2018 21:30:47 +0300 |
Hi all.
This fixes image fleecing scheme for 3.0, details are in 04 patch.
01 is a significant fix too.
v4:
01: fix copy_range architecture here too
02: rebase on 01
03: rebase
v3:
02: fix typo in assert, to fix build
v2:
01,02: new patches
03: - improve comment
- fix assert in bdrv_aligned_pwritev
- add asserts to not use the flag on read requests
- support copy_range
04: - expand "detected cases" range
- s/fleecing/serialize_target_writes
- support backup_cow_with_offload
- drop restriction on compressed writes
v1 cover:
It's a continuation of discussion under
"[PATCH v2 2/3] block/fleecing-filter: new filter driver for fleecing" [1].
Here is my try to implement Kevin's idea, that all backup writes (for
fleecing case) should be serialized. (However, I've skipped for now
fixing related permissions).
Looks like these patches may replace patch [1], to make fleecing scheme
safe. But I'm not sure, a look by Kevin is necessary.
A test is still needed, to prove that this patch is necessary and that it
works..
Vladimir Sementsov-Ogievskiy (4):
block/io: fix copy_range
block: split flags in copy_range
block: add BDRV_REQ_SERIALISING flag
block/backup: fix fleecing scheme: use serialized writes
include/block/block.h | 31 ++++++++-
include/block/block_int.h | 14 ++--
include/sysemu/block-backend.h | 3 +-
block/backup.c | 20 ++++--
block/block-backend.c | 5 +-
block/file-posix.c | 21 +++---
block/io.c | 147 ++++++++++++++++++++++++++++-------------
block/iscsi.c | 9 ++-
block/qcow2.c | 20 +++---
block/raw-format.c | 24 ++++---
qemu-img.c | 2 +-
11 files changed, 207 insertions(+), 89 deletions(-)
--
2.11.1
- [Qemu-block] [PATCH v4 0/4] fix image fleecing,
Vladimir Sementsov-Ogievskiy <=
[Qemu-block] [PATCH v4 4/4] block/backup: fix fleecing scheme: use serialized writes, Vladimir Sementsov-Ogievskiy, 2018/07/06
[Qemu-block] [PATCH v4 2/4] block: split flags in copy_range, Vladimir Sementsov-Ogievskiy, 2018/07/06
Re: [Qemu-block] [Qemu-devel] [PATCH v4 0/4] fix image fleecing, Eric Blake, 2018/07/06