[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size
From: |
Amol Surati |
Subject: |
Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes |
Date: |
Mon, 18 Jun 2018 23:54:53 +0530 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Mon, Jun 18, 2018 at 02:13:52PM -0400, John Snow wrote:
>
> On 06/18/2018 02:02 PM, Amol Surati wrote:
> > On Mon, Jun 18, 2018 at 12:05:15AM +0530, Amol Surati wrote:
> >> This patch fixes the assumption that io_buffer_size is always a perfect
> >> multiple of the sector size. The assumption is the cause of the firing
> >> of 'assert(n * 512 == s->sg.size);'.
> >>
> >> Signed-off-by: Amol Surati <address@hidden>
> >> ---
> >
> > The repository https://github.com/asurati/1777315 contains a module for
> > QEMU's 8086:7010 ATA controller, which exercises the code path
> > described in [RFC 0/1] of this series.
> >
> > Loading the module reproduces the bug. Tested on the latest master
> > branch.
> >
> > Steps:
. . .
. . .
> Are you the original reporter as well?
I am not the original reporter.
> I'm looking at the patch and the reproducer now, thanks.
>
> --js
-Amol
- [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes, Amol Surati, 2018/06/17
- Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes, Amol Surati, 2018/06/18
- Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes, John Snow, 2018/06/18
- Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes,
Amol Surati <=
- Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes, John Snow, 2018/06/18
- Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes, Amol Surati, 2018/06/19
- Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes, Kevin Wolf, 2018/06/19
- Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes, John Snow, 2018/06/19
- Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes, Amol Surati, 2018/06/19
- Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes, Amol Surati, 2018/06/19
- Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes, John Snow, 2018/06/19
- Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes, Amol Surati, 2018/06/19
- Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes, Amol Surati, 2018/06/19