[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 0/3] qcow2: Do not mark inactive images corru
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v2 0/3] qcow2: Do not mark inactive images corrupt |
Date: |
Sat, 9 Jun 2018 23:54:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 2018-06-06 21:36, Max Reitz wrote:
> The non-public logs in
> https://bugzilla.redhat.com/show_bug.cgi?id=1583346 (sorry...) reveal
> this problem:
>
> $ (Create a qcow2 file "foo.qcow2" with a corrupted first L1 entry)
> $ echo 'qemu-io none0 "read 0 512"' \
> | x86_64-softmmu/qemu-system-x86_64 -drive if=none,file=foo.qcow2 \
> -monitor stdio \
> -incoming exec:'cat /dev/null'
> QEMU 2.12.50 monitor - type 'help' for more information
> (qemu) qemu-io none0 "read 0 512"
> qcow2: Marking image as corrupt: L2 table offset 0x44200 unaligned (L1 index:
> 0); further corruption events will be suppressed
> qemu-system-x86_64: block/io.c:1691: bdrv_co_pwritev: Assertion
> `!(bs->open_flags & BDRV_O_INACTIVE)' failed.
> [1] 18444 done echo 'qemu-io none0 "read 0 512"' |
> 18445 abort (core dumped) x86_64-softmmu/qemu-system-x86_64 -drive
> if=none,file=foo.qcow2 -monitor stdi
>
> Oops.
>
>
> The first patch in this series makes a function public that the second
> patch uses to fix the issue by treating all non-writable images like
> read-only images (yes, there is a difference...) in this regard (which
> most importantly means not trying to set the corrupt flag on them).
> Inactive images count as non-writable images, but not as read-only
> images, so that fixes it.
>
> The third patch adds an iotest case.
Thanks for the reviews, applied to my block branch.
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 0/3] qcow2: Do not mark inactive images corrupt, Max Reitz, 2018/06/06
- [Qemu-block] [PATCH v2 1/3] block: Make bdrv_is_writable() public, Max Reitz, 2018/06/06
- [Qemu-block] [PATCH v2 2/3] qcow2: Do not mark inactive images corrupt, Max Reitz, 2018/06/06
- [Qemu-block] [PATCH v2 3/3] iotests: Add case for a corrupted inactive image, Max Reitz, 2018/06/06
- Re: [Qemu-block] [PATCH v2 0/3] qcow2: Do not mark inactive images corrupt, Max Reitz, 2018/06/06
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/3] qcow2: Do not mark inactive images corrupt, John Snow, 2018/06/06
- Re: [Qemu-block] [PATCH v2 0/3] qcow2: Do not mark inactive images corrupt,
Max Reitz <=