[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v9 00/10] qemu-img convert with copy offloading
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH v9 00/10] qemu-img convert with copy offloading |
Date: |
Mon, 4 Jun 2018 10:28:54 +0100 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Fri, Jun 01, 2018 at 05:26:38PM +0800, Fam Zheng wrote:
> v9: Don't break older libiscsi. [patchew]
>
> v8: Fix compiling against new glibc and libiscsi on Fedora 28 where v7 had
> conflict definitions. [Stefan, myself]
> - Add HAVE_COPY_FILE_RANGE in configure.
> - Drop IDENT_DESCR_TGT_DESCR from scsi constants header.
>
> v7: Fix qcow2.
>
> v6: Pick up rev-by from Stefan and Eric.
> Tweak patch 2 commit message.
>
> v5: - Fix raw offset/bytes check for read. [Eric]
> - Fix qcow2_handle_l2meta. [Stefan]
> - Add coroutine_fn whereever appropriate. [Stefan]
>
> v4: - Fix raw offset and size. [Eric]
> - iscsi: Drop unnecessary return values and variables in favor of
> constants. [Stefan]
> - qcow2: Handle small backing case. [Stefan]
> - file-posix: Translate ENOSYS to ENOTSUP. [Stefan]
> - API documentation and commit message. [Stefan]
> - Add rev-by to patches 3, 5 - 10. [Stefan, Eric]
>
> This series introduces block layer API for copy offloading and makes use of it
> in qemu-img convert.
>
> For now we implemented the operation in local file protocol with
> copy_file_range(2). Besides that it's possible to add similar to iscsi, nfs
> and potentially more.
>
> As far as its usage goes, in addition to qemu-img convert, we can emulate
> offloading in scsi-disk (handle EXTENDED COPY command), and use the API in
> block jobs too.
>
> Fam Zheng (10):
> block: Introduce API for copy offloading
> raw: Check byte range uniformly
> raw: Implement copy offloading
> qcow2: Implement copy offloading
> file-posix: Implement bdrv_co_copy_range
> iscsi: Query and save device designator when opening
> iscsi: Create and use iscsi_co_wait_for_task
> iscsi: Implement copy offloading
> block-backend: Add blk_co_copy_range
> qemu-img: Convert with copy offloading
>
> block/block-backend.c | 18 ++
> block/file-posix.c | 98 +++++++++-
> block/io.c | 97 ++++++++++
> block/iscsi.c | 314 +++++++++++++++++++++++++++++----
> block/qcow2.c | 229 ++++++++++++++++++++----
> block/raw-format.c | 96 +++++++---
> configure | 17 ++
> include/block/block.h | 32 ++++
> include/block/block_int.h | 38 ++++
> include/block/raw-aio.h | 10 +-
> include/scsi/constants.h | 4 +
> include/sysemu/block-backend.h | 4 +
> qemu-img.c | 50 +++++-
> 13 files changed, 908 insertions(+), 99 deletions(-)
>
> --
> 2.17.0
>
>
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature
- [Qemu-block] [PATCH v9 01/10] block: Introduce API for copy offloading, (continued)
- [Qemu-block] [PATCH v9 01/10] block: Introduce API for copy offloading, Fam Zheng, 2018/06/01
- [Qemu-block] [PATCH v9 02/10] raw: Check byte range uniformly, Fam Zheng, 2018/06/01
- [Qemu-block] [PATCH v9 03/10] raw: Implement copy offloading, Fam Zheng, 2018/06/01
- [Qemu-block] [PATCH v9 04/10] qcow2: Implement copy offloading, Fam Zheng, 2018/06/01
- [Qemu-block] [PATCH v9 05/10] file-posix: Implement bdrv_co_copy_range, Fam Zheng, 2018/06/01
- [Qemu-block] [PATCH v9 06/10] iscsi: Query and save device designator when opening, Fam Zheng, 2018/06/01
- [Qemu-block] [PATCH v9 07/10] iscsi: Create and use iscsi_co_wait_for_task, Fam Zheng, 2018/06/01
- [Qemu-block] [PATCH v9 08/10] iscsi: Implement copy offloading, Fam Zheng, 2018/06/01
- [Qemu-block] [PATCH v9 09/10] block-backend: Add blk_co_copy_range, Fam Zheng, 2018/06/01
- [Qemu-block] [PATCH v9 10/10] qemu-img: Convert with copy offloading, Fam Zheng, 2018/06/01
- Re: [Qemu-block] [PATCH v9 00/10] qemu-img convert with copy offloading,
Stefan Hajnoczi <=