[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 15/20] migration: use local path for local he
|
From: |
Juan Quintela |
|
Subject: |
Re: [Qemu-block] [PATCH v2 15/20] migration: use local path for local headers |
|
Date: |
Fri, 25 May 2018 20:27:03 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
I don't agree with the comment that they work by accident, it is
"by-design". But if you want to change the design, I agree with
removing "$ROOT" from the default include path.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Later, Juan.