[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] sheepdog: Remove unnecessary NULL check in sd_p
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH] sheepdog: Remove unnecessary NULL check in sd_prealloc() |
|
Date: |
Tue, 22 May 2018 13:12:05 +0200 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 18.05.2018 um 20:17 hat Peter Maydell geschrieben:
> In commit 8b9ad56e9cbfd852a, we removed the code that could result
> in our getting to sd_prealloc()'s out_with_err_set label with a
> NULL blk pointer. That makes the NULL check in the error-handling
> path unnecessary, and Coverity gripes about it (CID 1390636).
> Delete the redundant check.
>
> Signed-off-by: Peter Maydell <address@hidden>
In fact, it was unnecessary even before that, because blk_unref(NULL)
is valid (it does nothing).
Thanks, applied to the block branch.
Kevin