[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] nfs: Fix error path in nfs_options_qdict_to_qap
From: |
Jeff Cody |
Subject: |
Re: [Qemu-block] [PATCH] nfs: Fix error path in nfs_options_qdict_to_qapi() |
Date: |
Wed, 16 May 2018 13:10:38 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, May 16, 2018 at 06:10:34PM +0200, Kevin Wolf wrote:
> Don't throw away local_err, but propagate it to errp.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/nfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/nfs.c b/block/nfs.c
> index d6364d28bb..3349b67a76 100644
> --- a/block/nfs.c
> +++ b/block/nfs.c
> @@ -571,6 +571,7 @@ static BlockdevOptionsNfs
> *nfs_options_qdict_to_qapi(QDict *options,
> qobject_unref(crumpled);
>
> if (local_err) {
> + error_propagate(errp, local_err);
> return NULL;
> }
>
> --
> 2.13.6
>
Thanks,
Applied to my block branch:
git://github.com/codyprime/qemu-kvm-jtc block
-Jeff