qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 13/42] job: Move state transitions to Job


From: Max Reitz
Subject: Re: [Qemu-block] [PATCH 13/42] job: Move state transitions to Job
Date: Mon, 14 May 2018 16:20:52 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 2018-05-09 18:26, Kevin Wolf wrote:
> This moves BlockJob.status and the closely related functions
> (block_)job_state_transition() and (block_)job_apply_verb to Job. The
> two QAPI enums are renamed to JobStatus and JobVerb.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  qapi/block-core.json     |  14 +++----
>  include/block/blockjob.h |   3 --
>  include/qemu/job.h       |  13 ++++++
>  blockjob.c               | 102 
> +++++++++++------------------------------------
>  job.c                    |  56 ++++++++++++++++++++++++++
>  tests/test-blockjob.c    |  39 +++++++++---------
>  block/trace-events       |   2 -
>  trace-events             |   4 ++
>  8 files changed, 122 insertions(+), 111 deletions(-)

block-job-dismiss's documentation still mentions
BLOCK_JOB_STATUS_CONCLUDED, but that's cleaned up in patch 39, so I
don't mind giving a:

Reviewed-by: Max Reitz <address@hidden>

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]