Re: [Qemu-block] [Qemu-devel] [RFC PATCH 10/33] job: Add job_delete()

[Eric Blake]

On 04/24/2018 10:24 AM, Kevin Wolf wrote:
> This moves freeing the Job object and its fields from block_job_unref()
> to job_delete().
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---

> +++ b/job.c
> @@ -56,3 +56,9 @@ void *job_create(const char *job_id, const JobDriver 
> *driver, Error **errp)
>  
>      return job;
>  }
> +
> +void job_delete(Job *job)
> +{
> +    g_free(job->id);
> +    g_free(job);

Should this be free()-like, by being a no-op when NULL is passed in, on
the grounds that it might simplify some partial-construction error paths?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature