[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] qemu-iotests: update 185 output
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH] qemu-iotests: update 185 output |
Date: |
Tue, 3 Apr 2018 16:13:36 +0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 03.04.2018 um 16:03 hat Stefan Hajnoczi geschrieben:
> Commit 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 ("vl: introduce
> vm_shutdown()") added a bdrv_drain_all() call. As a side-effect of the
> drain operation the block job iterates one more time than before. The
> 185 output no longer matches and the test is failing now.
>
> It may be possible to avoid the superfluous block job iteration, but
> that type of patch is not suitable late in the QEMU 2.12 release cycle.
>
> This patch simply updates the 185 output file. The new behavior is
> correct, just not optimal, so make the test pass again.
>
> Fixes: 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 ("vl: introduce
> vm_shutdown()")
> Cc: Kevin Wolf <address@hidden>
> Cc: QingFeng Hao <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
Do you want to update the comment in the 185 test case code that
explains which values we expect?
Kevin