[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 24/36] rbd: Use qemu_rbd_connect() in qemu_rb
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v3 24/36] rbd: Use qemu_rbd_connect() in qemu_rbd_do_create() |
Date: |
Mon, 26 Feb 2018 13:25:41 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 2018-02-23 20:25, Kevin Wolf wrote:
> This is almost exactly the same code. The differences are that
> qemu_rbd_connect() supports BlockdevOptionsRbd.server and that the cache
> mode is set explicitly.
>
> Supporting 'server' is a welcome new feature for image creation.
> Caching is disabled by default, so leave it that way.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/rbd.c | 54 ++++++++++--------------------------------------------
> 1 file changed, 10 insertions(+), 44 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 17/36] gluster: Support .bdrv_co_create, (continued)
- [Qemu-block] [PATCH v3 17/36] gluster: Support .bdrv_co_create, Kevin Wolf, 2018/02/23
- [Qemu-block] [PATCH v3 18/36] rbd: Fix use after free in qemu_rbd_set_keypairs() error path, Kevin Wolf, 2018/02/23
- [Qemu-block] [PATCH v3 19/36] rbd: Factor out qemu_rbd_connect(), Kevin Wolf, 2018/02/23
- [Qemu-block] [PATCH v3 21/36] rbd: Pass BlockdevOptionsRbd to qemu_rbd_connect(), Kevin Wolf, 2018/02/23
- [Qemu-block] [PATCH v3 22/36] rbd: Support .bdrv_co_create, Kevin Wolf, 2018/02/23
- [Qemu-block] [PATCH v3 23/36] rbd: Assign s->snap/image_name in qemu_rbd_open(), Kevin Wolf, 2018/02/23
- [Qemu-block] [PATCH v3 20/36] rbd: Remove non-schema options from runtime_opts, Kevin Wolf, 2018/02/23
- [Qemu-block] [PATCH v3 24/36] rbd: Use qemu_rbd_connect() in qemu_rbd_do_create(), Kevin Wolf, 2018/02/23
- Re: [Qemu-block] [PATCH v3 24/36] rbd: Use qemu_rbd_connect() in qemu_rbd_do_create(),
Max Reitz <=
- [Qemu-block] [PATCH v3 25/36] nfs: Use QAPI options in nfs_client_open(), Kevin Wolf, 2018/02/23
- [Qemu-block] [PATCH v3 26/36] nfs: Support .bdrv_co_create, Kevin Wolf, 2018/02/23
- [Qemu-block] [PATCH v3 27/36] sheepdog: QAPIfy "redundancy" create option, Kevin Wolf, 2018/02/23
- [Qemu-block] [PATCH v3 28/36] sheepdog: Support .bdrv_co_create, Kevin Wolf, 2018/02/23
- [Qemu-block] [PATCH v3 29/36] ssh: Use QAPI BlockdevOptionsSsh object, Kevin Wolf, 2018/02/23
- [Qemu-block] [PATCH v3 30/36] ssh: QAPIfy host-key-check option, Kevin Wolf, 2018/02/23
- [Qemu-block] [PATCH v3 33/36] file-posix: Fix no-op bdrv_truncate() with falloc preallocation, Kevin Wolf, 2018/02/23
- [Qemu-block] [PATCH v3 31/36] ssh: Pass BlockdevOptionsSsh to connect_to_ssh(), Kevin Wolf, 2018/02/23