[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 1/2] iotest 033: add misaligned write-zeroes
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v2 1/2] iotest 033: add misaligned write-zeroes test via truncate |
Date: |
Fri, 23 Feb 2018 14:34:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 2018-02-12 14:14, Anton Nefedov wrote:
> This new test case only makes sense for qcow2 while iotest 033 is generic;
> however it matches the test purpose perfectly and also 033 contains those
> do_test() tricks to pass the alignment, which won't look nice being
> duplicated in other tests or moved to the common code.
>
> Signed-off-by: Anton Nefedov <address@hidden>
> ---
> tests/qemu-iotests/033 | 28 ++++++++++++++++++++++++++++
> tests/qemu-iotests/033.out | 13 +++++++++++++
> 2 files changed, 41 insertions(+)
>
> diff --git a/tests/qemu-iotests/033 b/tests/qemu-iotests/033
> index 2cdfd13..5fa3983 100755
> --- a/tests/qemu-iotests/033
> +++ b/tests/qemu-iotests/033
> @@ -64,6 +64,9 @@ do_test()
> } | $QEMU_IO $IO_EXTRA_ARGS
> }
>
> +echo
> +echo "=== Test aligned and misaligned write zeroes operations ==="
> +
> for write_zero_cmd in "write -z" "aio_write -z"; do
> for align in 512 4k; do
> echo
> @@ -102,7 +105,32 @@ for align in 512 4k; do
> done
> done
>
> +
> +# Trigger truncate that would shrink qcow2 L1 table, which is done by
> +# clearing one entry (8 bytes) with bdrv_co_pwrite_zeroes()
> +
> +echo
> +echo "=== Test misaligned write zeroes via truncate ==="
> +echo
> +
> +CLUSTER_SIZE=$((64 * 1024))
> +L2_COVERAGE=$(($CLUSTER_SIZE * $CLUSTER_SIZE / 8))
> +_make_test_img $(($L2_COVERAGE * 2))
There should be a _cleanup_test_img before this or this test will fail
with nbd.
Max
signature.asc
Description: OpenPGP digital signature