[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 20/27] ssh: Use QAPI BlockdevOptionsSsh object
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [PATCH 20/27] ssh: Use QAPI BlockdevOptionsSsh object |
|
Date: |
Mon, 12 Feb 2018 18:17:34 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 2018-02-08 20:23, Kevin Wolf wrote:
> Create a BlockdevOptionsSsh object in connect_to_ssh() and take the
> options from there. 'host_key_check' is still processed separately
> because it's not in the schema yet.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/ssh.c | 136
> +++++++++++++++++++++++++++---------------------------------
> 1 file changed, 61 insertions(+), 75 deletions(-)
You might want to base this patch on Pino's patch to use libssh instead
of libssh2.
Anyway:
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH 15/27] rbd: Support .bdrv_co_create, (continued)
- [Qemu-block] [PATCH 16/27] nfs: Use QAPI options in nfs_client_open(), Kevin Wolf, 2018/02/08
- [Qemu-block] [PATCH 17/27] nfs: Support .bdrv_co_create, Kevin Wolf, 2018/02/08
- [Qemu-block] [PATCH 19/27] sheepdog: Support .bdrv_co_create, Kevin Wolf, 2018/02/08
- [Qemu-block] [PATCH 18/27] sheepdog: QAPIfy "redundacy" create option, Kevin Wolf, 2018/02/08
- [Qemu-block] [PATCH 20/27] ssh: Use QAPI BlockdevOptionsSsh object, Kevin Wolf, 2018/02/08
- Re: [Qemu-block] [PATCH 20/27] ssh: Use QAPI BlockdevOptionsSsh object,
Max Reitz <=
- [Qemu-block] [PATCH 21/27] ssh: QAPIfy host-key-check option, Kevin Wolf, 2018/02/08
- [Qemu-block] [PATCH 22/27] ssh: Pass BlockdevOptionsSsh to connect_to_ssh(), Kevin Wolf, 2018/02/08
- [Qemu-block] [PATCH 23/27] ssh: Support .bdrv_co_create, Kevin Wolf, 2018/02/08
- [Qemu-block] [PATCH 24/27] file-posix: Fix no-op bdrv_truncate() with falloc preallocation, Kevin Wolf, 2018/02/08
- [Qemu-block] [PATCH 25/27] block: Fail bdrv_truncate() with negative size, Kevin Wolf, 2018/02/08