[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] iotests: 205: support luks format
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-block] [PATCH] iotests: 205: support luks format |
Date: |
Tue, 6 Feb 2018 17:29:07 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Tue, Feb 06, 2018 at 08:16:42PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Support default luks options in VM.add_drive and in new library
> function qemu_img_create. Use it in 205 iotests.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>
> instead of
> [PATCH] iotests: 205: support only raw format
>
> let's just support luks. This patch also makes it simple to support
> luks in any other python iotest.
>
> tests/qemu-iotests/205 | 4 ++--
> tests/qemu-iotests/iotests.py | 33 +++++++++++++++++++++++++++++++++
> 2 files changed, 35 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index 5a10b2d534..4b9a4445cd 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -58,6 +58,13 @@ qemu_default_machine =
> os.environ.get('QEMU_DEFAULT_MACHINE')
> socket_scm_helper = os.environ.get('SOCKET_SCM_HELPER', 'socket_scm_helper')
> debug = False
>
> +luks_default_secret_id = 'luks_secret_default_iotests_id'
Can we just call this "keysec0", so we matchh convention used by
the shell script based tests.
> +luks_default_secret_data = '12345'
The 'check' script exports an environment variable IMGKEYSECRET
that is intended to be used as the default password for LUKS.
> +luks_default_secret_object = 'secret,id=' + luks_default_secret_id + \
> + ',data=' + luks_default_secret_data
> +luks_default_key_secret_opt = 'key-secret=' + luks_default_secret_id
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|