[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v8 05/26] block: Respect backing bs in bdrv_refr
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH v8 05/26] block: Respect backing bs in bdrv_refresh_filename |
|
Date: |
Tue, 06 Feb 2018 15:00:05 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 05 Feb 2018 04:18:14 PM CET, Max Reitz wrote:
> Basically, bdrv_refresh_filename() should respect all children of a
> BlockDriverState. However, generally those children are driver-specific,
> so this function cannot handle the general case. On the other hand,
> there are only few drivers which use other children than @file and
> @backing (that being vmdk, quorum, and blkverify).
>
> Most block drivers only use @file and/or @backing (if they use any
> children at all). Both can be implemented directly in
> bdrv_refresh_filename.
>
> The user overriding the file's filename is already handled, however, the
> user overriding the backing file is not. If this is done, opening the
> BDS with the plain filename of its file will not be correct, so we may
> not set bs->exact_filename in that case.
>
> iotests 051 and 191 contain test cases for overwriting the backing file,
> and so their output changes with this patch applied (which I consider a
> good thing). Note that in the case of 191, the implicitly opened
> (non-overridden) base file is included in the json:{} filename as well
> -- this will be remedied by a later patch.
>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Berto
- Re: [Qemu-block] [PATCH v8 03/26] block: Add BDS.backing_overridden, (continued)
- Re: [Qemu-block] [PATCH v8 03/26] block: Add BDS.backing_overridden, Max Reitz, 2018/02/22
- Re: [Qemu-block] [PATCH v8 03/26] block: Add BDS.backing_overridden, Kevin Wolf, 2018/02/22
- Re: [Qemu-block] [PATCH v8 03/26] block: Add BDS.backing_overridden, Max Reitz, 2018/02/22
- Re: [Qemu-block] [PATCH v8 03/26] block: Add BDS.backing_overridden, Kevin Wolf, 2018/02/22
- Re: [Qemu-block] [PATCH v8 03/26] block: Add BDS.backing_overridden, Max Reitz, 2018/02/22
[Qemu-block] [PATCH v8 04/26] iotests: Drop explicit base blockdev in 191, Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 05/26] block: Respect backing bs in bdrv_refresh_filename, Max Reitz, 2018/02/05
- Re: [Qemu-block] [PATCH v8 05/26] block: Respect backing bs in bdrv_refresh_filename,
Alberto Garcia <=
[Qemu-block] [PATCH v8 06/26] block: Make path_combine() return the path, Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 07/26] block: bdrv_get_full_backing_filename_from_...'s ret. val., Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 08/26] block: bdrv_get_full_backing_filename's ret. val., Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 09/26] block: Add bdrv_make_absolute_filename(), Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 10/26] block: Fix bdrv_find_backing_image(), Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 11/26] block: Add bdrv_dirname(), Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 12/26] blkverify: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 13/26] quorum: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 14/26] block/nbd: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05