[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2] block: maintain persistent disabled bitmaps
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [PATCH v2] block: maintain persistent disabled bitmaps |
|
Date: |
Wed, 31 Jan 2018 20:04:06 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 2018-01-29 19:43, Max Reitz wrote:
> On 2018-01-22 11:41, Vladimir Sementsov-Ogievskiy wrote:
>> To maintain load/store disabled bitmap there is new approach:
>>
>> - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored
>> - store enabled bitmaps as "auto" to qcow2
>> - store disabled bitmaps without "auto" flag to qcow2
>> - on qcow2 open load "auto" bitmaps as enabled and others
>> as disabled (except in_use bitmaps)
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> Reviewed-by: John Snow <address@hidden>
>> ---
>
> Thanks, looks very reasonable. Applied to my block branch:
>
> https://github.com/XanClic/qemu/commits/block
...aaand I've only just now seen that iotest 176 will need to be fixed
along with this, so I'm going to unqueue this patch for now.
And when I'm already at it: Should we add deprecation information to
qemu-doc.texi?
Max
signature.asc
Description: OpenPGP digital signature