[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] qcow2: Replace align_offset() with ROUND_UP()
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH] qcow2: Replace align_offset() with ROUND_UP() |
|
Date: |
Tue, 30 Jan 2018 17:08:56 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 30 Jan 2018 05:03:16 PM CET, Eric Blake wrote:
>> - virtual_size = align_offset(qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE,
>> 0),
>> + virtual_size = ROUND_UP(qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0),
>> cluster_size);
I just realized that the first parameter here is a function call with
side effects, it it safe to use ROUND_UP() in this case?
#define ROUND_UP(n, d) (((n) + (d) - 1) & -(0 ? (n) : (d)))
Berto