[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 3/9] block: Add VFIO based NVMe driver
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [PATCH v4 3/9] block: Add VFIO based NVMe driver |
Date: |
Fri, 12 Jan 2018 11:09:54 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Wed, 01/10 18:33, Stefan Hajnoczi wrote:
> > + ret = event_notifier_init(&s->irq_notifier, 0);
> > + if (ret) {
> > + error_setg(errp, "Failed to init event notifier");
> > + return ret;
>
> dma_map_lock should be destroyed.
CoMutexes are initialized by memset so I don't think destroying is necessary:
void qemu_co_mutex_init(CoMutex *mutex)
{
memset(mutex, 0, sizeof(*mutex));
}
(I agree to and will fix other issues you pointed out. Thanks for the quick
review!)
Fam
- Re: [Qemu-block] [Qemu-devel] [PATCH v4 2/9] util: Introduce vfio helpers, (continued)
- [Qemu-block] [PATCH v4 3/9] block: Add VFIO based NVMe driver, Fam Zheng, 2018/01/10
- [Qemu-block] [PATCH v4 4/9] block: Introduce buf register API, Fam Zheng, 2018/01/10
- [Qemu-block] [PATCH v4 5/9] block/nvme: Implement .bdrv_(un)register_buf, Fam Zheng, 2018/01/10
- [Qemu-block] [PATCH v4 6/9] qemu-img: Map bench buffer, Fam Zheng, 2018/01/10
- [Qemu-block] [PATCH v4 8/9] docs: Add section for NVMe VFIO driver, Fam Zheng, 2018/01/10
- [Qemu-block] [PATCH v4 7/9] block: Move NVMe constants to a separate header, Fam Zheng, 2018/01/10