[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v6 03/20] file-posix: Switch to .bdrv_co_block_s

From: Fam Zheng
Subject: Re: [Qemu-block] [PATCH v6 03/20] file-posix: Switch to .bdrv_co_block_status()
Date: Fri, 29 Dec 2017 10:41:51 +0800
User-agent: Mutt/1.9.1 (2017-09-22)

On Thu, 12/07 14:30, Eric Blake wrote:
> We are gradually moving away from sector-based interfaces, towards
> byte-based.  Update the file protocol driver accordingly.
> In want_zero mode, we continue to report fine-grained hole
> information (the caller wants as much mapping detail as possible);
> but when not in that mode, the caller prefers larger *pnum and
> merely cares about what offsets are allocated at this layer, rather
> than where the holes live.  Since holes still read as zeroes at
> this layer (rather than deferring to a backing layer), we can take
> the shortcut of skipping lseek(), and merely state that all bytes
> are allocated.
> We can also drop redundant bounds checks that are already
> guaranteed by the block layer.
> Signed-off-by: Eric Blake <address@hidden>

Reviewed-by: Fam Zheng <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]