[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v9 01/13] block/dirty-bitmap: add b
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v9 01/13] block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor() |
Date: |
Thu, 28 Dec 2017 13:16:37 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Wed, 12/20 18:49, Vladimir Sementsov-Ogievskiy wrote:
> Enabling bitmap successor is necessary to enable successors of bitmaps
> being migrated before target vm start.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Reviewed-by: John Snow <address@hidden>
> ---
> include/block/dirty-bitmap.h | 1 +
> block/dirty-bitmap.c | 8 ++++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/include/block/dirty-bitmap.h b/include/block/dirty-bitmap.h
> index 3579a7597c..93d4336505 100644
> --- a/include/block/dirty-bitmap.h
> +++ b/include/block/dirty-bitmap.h
> @@ -20,6 +20,7 @@ BdrvDirtyBitmap
> *bdrv_dirty_bitmap_abdicate(BlockDriverState *bs,
> BdrvDirtyBitmap *bdrv_reclaim_dirty_bitmap(BlockDriverState *bs,
> BdrvDirtyBitmap *bitmap,
> Error **errp);
> +void bdrv_dirty_bitmap_enable_successor(BdrvDirtyBitmap *bitmap);
> BdrvDirtyBitmap *bdrv_find_dirty_bitmap(BlockDriverState *bs,
> const char *name);
> void bdrv_dirty_bitmap_make_anon(BdrvDirtyBitmap *bitmap);
> diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
> index bd04e991b1..81adbeb6d4 100644
> --- a/block/dirty-bitmap.c
> +++ b/block/dirty-bitmap.c
> @@ -237,6 +237,14 @@ int bdrv_dirty_bitmap_create_successor(BlockDriverState
> *bs,
> return 0;
> }
>
> +/* Called with BQL taken. */
> +void bdrv_dirty_bitmap_enable_successor(BdrvDirtyBitmap *bitmap)
> +{
> + qemu_mutex_lock(bitmap->mutex);
> + bdrv_enable_dirty_bitmap(bitmap->successor);
> + qemu_mutex_unlock(bitmap->mutex);
> +}
> +
> /**
> * For a bitmap with a successor, yield our name to the successor,
> * delete the old bitmap, and return a handle to the new bitmap.
> --
> 2.11.1
>
>
Reviewed-by: Fam Zheng <address@hidden>
- [Qemu-block] [PATCH v9 06/13] qapi: add dirty-bitmaps migration capability, (continued)
- [Qemu-block] [PATCH v9 06/13] qapi: add dirty-bitmaps migration capability, Vladimir Sementsov-Ogievskiy, 2017/12/20
- [Qemu-block] [PATCH v9 11/13] iotests: add default node-name, Vladimir Sementsov-Ogievskiy, 2017/12/20
- [Qemu-block] [PATCH v9 03/13] block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap, Vladimir Sementsov-Ogievskiy, 2017/12/20
- [Qemu-block] [PATCH v9 13/13] iotests: add dirty bitmap postcopy test, Vladimir Sementsov-Ogievskiy, 2017/12/20
- [Qemu-block] [PATCH v9 08/13] migration/qemu-file: add qemu_put_counted_string(), Vladimir Sementsov-Ogievskiy, 2017/12/20
- [Qemu-block] [PATCH v9 01/13] block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor(), Vladimir Sementsov-Ogievskiy, 2017/12/20
- Re: [Qemu-block] [Qemu-devel] [PATCH v9 01/13] block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor(),
Fam Zheng <=
- [Qemu-block] [PATCH v9 04/13] dirty-bitmap: add locked state, Vladimir Sementsov-Ogievskiy, 2017/12/20
- [Qemu-block] [PATCH v9 12/13] iotests: add dirty bitmap migration test, Vladimir Sementsov-Ogievskiy, 2017/12/20
- [Qemu-block] [PATCH v9 05/13] migration: introduce postcopy-only pending, Vladimir Sementsov-Ogievskiy, 2017/12/20
- [Qemu-block] [PATCH v9 09/13] migration: add is_active_iterate handler, Vladimir Sementsov-Ogievskiy, 2017/12/20