[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH] block: Document that x-blockdev-change breaks quoru
[Qemu-block] [PATCH] block: Document that x-blockdev-change breaks quorum children list
Fri, 15 Dec 2017 11:59:05 +0100
Removing a quorum child node with x-blockdev-change results in a quorum
driver state that cannot be recreated with create options because it
would require a list with gaps. This causes trouble in at least
Document this problem so that we won't accidentally mark the command
stable without having addressed it.
Signed-off-by: Kevin Wolf <address@hidden>
qapi/block-core.json | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index dd763dcf87..4cc1389834 100644
@@ -3918,6 +3918,10 @@
# does not support all kinds of operations, all kinds of children, nor
# all block drivers.
+# FIXME Removing children from a quorum node means introducing gaps in the
+# child indices. This cannot be represented in the 'children' list of
+# BlockdevOptionsQuorum, as returned by .bdrv_refresh_filename().
# Warning: The data in a new quorum child MUST be consistent with that of
# the rest of the array.
- [Qemu-block] [PATCH] block: Document that x-blockdev-change breaks quorum children list,
Kevin Wolf <=