[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH 06/14] sdhci: refactor same sysbus/

From: Paolo Bonzini
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH 06/14] sdhci: refactor same sysbus/pci properties into a common one
Date: Fri, 15 Dec 2017 09:10:17 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 14/12/2017 19:40, Philippe Mathieu-Daudé wrote:
>>> +    DEFINE_PROP_BOOL("pending-insert-quirk", SDHCIState, 
>>> pending_insert_quirk,
>>> +                     false),
>> I like the reduction of code in this patch, but aren't we now going to
>> have device properties that aren't actually connected to anything?
> I'm not sure I understand, ar you worried about the PCI_SDHCI will now
> have this property but not use it?
> I couldn't find any machine using SDHCI via PCI and was tempted to
> just remove this code,

PCI devices can be created with -device, they don't have to be added by


reply via email to

[Prev in Thread] Current Thread [Next in Thread]