[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH 4/7] blockjob: allow block_job_thro

From: John Snow
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH 4/7] blockjob: allow block_job_throttle to take delay_ns
Date: Thu, 14 Dec 2017 12:22:47 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 12/14/2017 12:21 PM, Paolo Bonzini wrote:
> On 14/12/2017 17:06, John Snow wrote:
>>> And another question.  After this series there is exactly one
>>> block_job_sleep_ns call (in block/mirror.c).  Perhaps instead of
>>> block_job_throttle, you should refine block_job_sleep_ns?
>> Yeah, maybe? "A rose by any other name," though -- I think I might be
>> coming for the block/mirror call next because I have one more downstream
>> BZ that references this as a job that can cause the warning print.
>> So maybe we'll just have throttle calls instead of sleep calls from here
>> on out.
> Ok, shall we wait for v2 where you look at that BZ as well?
> Thanks,
> Paolo

Sure -- if the only feedback you have on this series is primarily style
and "maybe there are some more wins" I can spin a v2 to try to broaden
the scope if it looks good so far.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]