[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] iotests: Tweak 030 in order to trigger a race c
Re: [Qemu-block] [PATCH] iotests: Tweak 030 in order to trigger a race condition with parallel jobs
Wed, 13 Dec 2017 12:31:20 +0100
Am 07.12.2017 um 18:08 hat Alberto Garcia geschrieben:
> This patch tweaks TestParallelOps in iotest 030 so it allocates data
> in smaller regions (256KB/512KB instead of 512KB/1MB) and the
> block-stream job in test_stream_commit() only needs to copy data that
> is at the very end of the image.
> This way when the block-stream job is waken up it will finish right
> away without any chance of being stopped by block_job_sleep_ns(). This
> triggers the bug that was fixed by 3d5d319e1221082974711af1d09d82f07
> and is therefore a more useful test case for parallel block jobs.
But if all jobs complete right away, doesn't this kill the parallelism
that the test case intended to test?
Maybe we need both cases?