[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block/iscsi: only report an iS

From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block/iscsi: only report an iSCSI Failure if we don't handle it gracefully
Date: Fri, 8 Dec 2017 09:11:43 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 12/08/2017 05:51 AM, Peter Lieven wrote:
> we currently report an "iSCSI Failure" in iscsi_co_generic_cb if the task
> hasn't completed with SCSI_STATUS_GOOD. However, we expect a failure in
> some cases and handle it gracefully. This is the case for misaligned UNMAPs

Is the block layer still capable of producing a misaligned UNMAP?  If
so, that's probably a bug in the block layer for not honoring the block
limit geometries.

> and WRITESAME10/16 calls without UNMAP. In this case a failure in the
> logs can be quite misleading.
> While we are at it improve the logging to reveal which operation failed
> at what LBA.
> Signed-off-by: Peter Lieven <address@hidden>
> ---
>  block/iscsi.c | 43 ++++++++++++++++++++++++++++++++-----------
>  1 file changed, 32 insertions(+), 11 deletions(-)

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]