[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-io: fix EOF Ctrl-D handling i

From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-io: fix EOF Ctrl-D handling in qemu-io readline code
Date: Wed, 6 Dec 2017 08:30:27 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 12/06/2017 08:25 AM, Daniel P. Berrange wrote:

>> Should we instead be looking for a match against the current termios()
>> c_cc[VEOF] setting, in case the user prefers something other than ^D via
>> stty?  Does readline provide any functionality for automating this?
> I was afraid someone was going to suggest doing that. I was being lazy by
> hardcoding Ctrl-D, but yes the real readline() library will honour the
> VEOF value.  QEMU though is using a home-grown reimpl of readline...

I understand why we can't use modern libreadline (it is licensed GPLv3+,
making it impossible to use with our GPLv2-only code) - but doesn't BSD
have a readline-alike library with BSD licensing that we could use
instead of implementing readline ourselves?  (Was it named libinput?)

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]