[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH 1/7] qapi: add unmap to BlockDevice

From: Anton Nefedov
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH 1/7] qapi: add unmap to BlockDeviceStats
Date: Tue, 5 Dec 2017 20:15:29 +0300
User-agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 5/12/2017 6:19 PM, Eric Blake wrote:
On 12/05/2017 09:09 AM, Alberto Garcia wrote:
On Mon 20 Nov 2017 05:50:58 PM CET, Anton Nefedov wrote:
Signed-off-by: Anton Nefedov <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
  qapi/block-core.json       | 20 ++++++++++++++++++++
  include/block/accounting.h |  1 +
  block/qapi.c               |  6 ++++++
  3 files changed, 27 insertions(+)

Admittedtly this is just a style issue and I don't know what others
think, but wouldn't it be nicer if the documentation of new fields is
located together with the existing ones?



Grouping is fine, and your suggestion makes sense to me.  One of the
nice things of QMP is that since it is name/value based, you don't have
to worry about inserting a name in the middle if that makes more sense
logically (it doesn't break backwards compatibility with old QMP
clients, the way that inserting something into the middle of a C struct
breaks all callers that were using the old struct layout).

Thank you, agree, will fix


reply via email to

[Prev in Thread] Current Thread [Next in Thread]