[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 5/5] iotests: Make 136 less flaky
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 5/5] iotests: Make 136 less flaky |
Date: |
Thu, 9 Nov 2017 08:15:32 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/08/2017 07:38 PM, Max Reitz wrote:
> 136 executes some AIO requests without a final aio_flush; then it
> advances the virtual clock and thus expects the last access time of the
> device to be less than the current time when queried (i.e. idle_time_ns
> to be greater than 0). However, without the aio_flush, some requests
> may be settled after the clock_step invocation. In that case,
> idle_time_ns would be 0 and the test fails.
>
> Fix this by adding an aio_flush if any AIO request but some other
s/but/other than/
> aio_flush has been executed.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/136 | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 1/5] iotests: Make 030 less flaky, (continued)
- [Qemu-block] [PATCH 1/5] iotests: Make 030 less flaky, Max Reitz, 2017/11/08
- [Qemu-block] [PATCH 2/5] iotests: Add missing 'blkdebug::' in 040, Max Reitz, 2017/11/08
- [Qemu-block] [PATCH 3/5] iotests: Make 055 less flaky, Max Reitz, 2017/11/08
- [Qemu-block] [PATCH 4/5] iotests: Make 083 less flaky, Max Reitz, 2017/11/08
- [Qemu-block] [PATCH 5/5] iotests: Make 136 less flaky, Max Reitz, 2017/11/08
- Re: [Qemu-block] [Qemu-devel] [PATCH 5/5] iotests: Make 136 less flaky,
Eric Blake <=
- Re: [Qemu-block] [PATCH 0/5] iotests: Make some tests less flaky, Stefan Hajnoczi, 2017/11/09