[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/5] qemu-iotests: Allow QMP pretty printing in
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 3/5] qemu-iotests: Allow QMP pretty printing in common.qemu |
Date: |
Mon, 25 Sep 2017 14:43:28 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/25/2017 07:28 AM, Kevin Wolf wrote:
> QMP responses to certain commands can become quite long, which doesn't
> only make reading them hard, but also means that the maximum line length
> in patch emails can be exceeded. Allow tests to switch to QMP pretty
> printing, which results in more, but shorter lines.
>
> We also need to make sure to keep indentation in the response for this
> to work as expected.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> tests/qemu-iotests/common.qemu | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
Nice!
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 0/5] commit: Support multiple roots above top node, Kevin Wolf, 2017/09/25
- [Qemu-block] [PATCH 3/5] qemu-iotests: Allow QMP pretty printing in common.qemu, Kevin Wolf, 2017/09/25
- Re: [Qemu-block] [PATCH 3/5] qemu-iotests: Allow QMP pretty printing in common.qemu,
Eric Blake <=
- [Qemu-block] [PATCH 1/5] block: Introduce BdrvChildRole.update_filename, Kevin Wolf, 2017/09/25
- [Qemu-block] [PATCH 2/5] commit: Support multiple roots above top node, Kevin Wolf, 2017/09/25
- [Qemu-block] [PATCH 4/5] qemu-iotests: Test commit block job where top has two parents, Kevin Wolf, 2017/09/25
- [Qemu-block] [PATCH 5/5] commit: Remove overlay_bs, Kevin Wolf, 2017/09/25
- Re: [Qemu-block] [PATCH 0/5] commit: Support multiple roots above top node, John Snow, 2017/09/25