[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 06/10] qemu-iotests: do not include common.rc in "ch
From: |
Paolo Bonzini |
Subject: |
[Qemu-block] [PATCH 06/10] qemu-iotests: do not include common.rc in "check" |
Date: |
Tue, 12 Sep 2017 16:44:55 +0200 |
It only provides functions used by the test programs.
Signed-off-by: Paolo Bonzini <address@hidden>
---
tests/qemu-iotests/check | 6 ------
tests/qemu-iotests/common.rc | 13 +++++--------
2 files changed, 5 insertions(+), 14 deletions(-)
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index b7c54390d3..4cb5b05908 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -72,12 +72,6 @@ then
_init_error "failed to source common.config"
fi
-# we need common.rc
-if ! . "$source_iotests/common.rc"
-then
- _init_error "failed to source common.rc"
-fi
-
# we need common
. "$source_iotests/common"
diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
index e7f74b4dbd..20f6821a69 100644
--- a/tests/qemu-iotests/common.rc
+++ b/tests/qemu-iotests/common.rc
@@ -40,14 +40,11 @@ poke_file()
printf "$3" | dd "of=$1" bs=1 "seek=$2" conv=notrunc &>/dev/null
}
-# we need common.config
-if [ "$iam" != "check" ]
-then
- if ! . ./common.config
- then
- echo "$iam: failed to source common.config"
- exit 1
- fi
+
+if ! . ./common.config
+ then
+ echo "$iam: failed to source common.config"
+ exit 1
fi
_qemu_wrapper()
--
2.13.5
- Re: [Qemu-block] [Qemu-devel] [PATCH 02/10] qemu-iotests: get rid of AWK_PROG, (continued)
- [Qemu-block] [PATCH 06/10] qemu-iotests: do not include common.rc in "check",
Paolo Bonzini <=
- [Qemu-block] [PATCH 05/10] qemu-iotests: limit non-_PROG-suffixed variables to common.rc, Paolo Bonzini, 2017/09/12
- [Qemu-block] [PATCH 07/10] qemu-iotests: disintegrate more parts of common.config, Paolo Bonzini, 2017/09/12
- [Qemu-block] [PATCH 08/10] qemu-iotests: fix uninitialized variable, Paolo Bonzini, 2017/09/12
- [Qemu-block] [PATCH 10/10] qemu-iotests: merge "check" and "common", Paolo Bonzini, 2017/09/12
- [Qemu-block] [PATCH 09/10] qemu-iotests: get rid of $iam, Paolo Bonzini, 2017/09/12